[Tickets #4794] Re: Wrong eventduration with imported calendars

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=4794
-----------------------------------------------------------------------
 Ticket             | 4794
 Updated By         | avo at trustsec.de
 Summary            | Wrong eventduration with imported calendars 
 Queue              | Kronolith
 Version            | HEAD
 Type               | Bug
 State              | Feedback
 Priority           | 2. Medium
 Owners             | 
+New Attachment     | Driver.php.diff
-----------------------------------------------------------------------


avo at trustsec.de (2007-02-07 10:30) wrote:

ianh (at) hardersoft (dot) com writes:

> [...] Importing Canadian Calendars made all full day events span two
> days. The calculated end date was increased by one day.
>
> Also, when viewing events remotely (through webdav interface) in
> Lightening, the end dates were shown one day too soon. [...]

It seems to be wrong to add a day to the end of an all-day event in
kronolith/lib/Driver.php.  Also, I think that it is wrong to subtract a
day from the end date when exporting an all-day event.  I've attached a
patch that changes Driver.php accordingly.

There seems to be another bug in Driver.php. One of the comments says
that DTEND matches YYYYMMDDT2359(59|00), i.e. the second may be 59 or
00.  But the code doesn't check whether the _minute_ is 59; instead
the code checks whether the _second_ is 59.  This bug gets also fixed
by our patch.