[Tickets #4890] Re: preferences: use_trash disables delhide

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=4890
-----------------------------------------------------------------------
 Ticket             | 4890
 Updated By         | lmamane at debian.org
 Summary            | preferences: use_trash disables delhide
 Queue              | IMP
 Version            | 4.1.3
 Type               | Bug
 State              | Not A Bug
 Priority           | 1. Low
 Owners             | 
-----------------------------------------------------------------------


lmamane at debian.org (2007-02-10 03:30) wrote:

I remain unvoncinced. Delete-but-not-expunged messages can be left by other
applications than IMP. The user may wish to hide those. I see no point in
removing that choice from the user. What is *achieved* by that?

I'm applying this patch to the version distributed by Debian:

--- orig/lib/Mailbox.php
+++ mod/lib/Mailbox.php
@@ -171,7 +171,6 @@
             $this->_delhide = !$GLOBALS['imp_search']->isVTrashFolder();
         } else {
             $this->_delhide = ($GLOBALS['prefs']->getValue('delhide') &&
-                               !$GLOBALS['prefs']->getValue('use_trash')
&&
                                ($GLOBALS['imp_search']->isSearchMbox()
||
                                ($GLOBALS['prefs']->getValue('sortby') !=
SORTTHREAD)));
         }