[Tickets #4991] Re: Default identity not selected correctly when replying to or forwarding messages in Inbox

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=4991
-----------------------------------------------------------------------
 Ticket             | 4991
 Updated By         | boutilpj at ednet.ns.ca
 Summary            | Default identity not selected correctly when replying to or forwarding
                    | messages in Inbox
 Queue              | IMP
 Version            | 4.1.3
 Type               | Bug
 State              | Feedback
 Priority           | 2. Medium
 Owners             | 
-----------------------------------------------------------------------


boutilpj at ednet.ns.ca (2007-02-15 12:05) wrote:

Ok, starting at line 493 of imp/message.php :

if (count($msgAddresses)) {
        $identity = $user_identity->getMatchingIdentity($msgAddresses);
        if (!is_null($identity) ||
            $user_identity->getMatchingIdentity($msgAddresses, false) !==
null) {
            $status .= Horde::img('mail_personal.png', _("Personal"));
        }
        if (is_null($identity)) {
            $identity = $user_identity->getDefault();
        }
    }

Since from_addr pref is locked all the identities have the same e-mail
address it will always pick identity 0 . I can see why the code would do
this if the identities all had different e-mail addresses. In our
situation, where we basically only allow different signatures per identity
this does not work.

Will have to think about it for a bit. :-)