[Tickets #5012] Re: wrong trash folder options check in Message.php delete()

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=5012
-----------------------------------------------------------------------
 Ticket             | 5012
 Updated By         | stephan at stean.ch
 Summary            | wrong trash folder options check in Message.php delete()
 Queue              | IMP
 Version            | 4.1.3
 Type               | Bug
 State              | Feedback
 Priority           | 1. Low
 Owners             | 
-----------------------------------------------------------------------


stephan at stean.ch (2007-02-23 23:55) wrote:

> No, $prefs->getValue('trash_folder') will return the default value 
> from config/prefs.php when the user hasn't set a folder yet, and if 
> you haven't broken your system.

I thought about having broken something too. But found nothing, and all
the
other settings from prefs.php where readable. So I made a test with a
vanilla
installation, with minor changes in servers.php. And came to the same
results.

Here what happens:

Mail options "Deleting and Moving messages", I enable the "When deleting
messages, move..."
option. But dont choose a trash folder from the list. IMP will insert an
empty trash_folder into the
horde_prefs table.

However, if I enable the very same option, choose "Create a new
trashfolder", instead of entering
the name press the cancel button, it works. IMP wont insert the empty
trash_folder into the
horde_prefs table and uses the prefs.php setting.

And of course if giving a name for the trash folder when asked for,
instead of pressing cancel,
that one will be used by IMP. 

So, the problem is quite somewhere else, namely in the page processing of
the IMP options.
imp/lib/prefs.php  function handlefolders($updated, $pref, $folder, $new)
does the following:
            if ($folder == IMP_PREF_NO_FOLDER) {
                $prefs->setValue($pref, '');
            } else {
I think when a user chooses to move deleted messages to a trash folder
this code fragment
does the wrong job. It should do as in the else part that follows, choose
an appropriate trash
folder name and use it.

Thats the way I think about it.