[Tickets #5041] Sync.php: createUidMap not called for last entry in each message

[bugs@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=5041
-----------------------------------------------------------------------
 Ticket             | 5041
 Created By         | patrick.abiven at apitech.fr
 Summary            | Sync.php: createUidMap not called for last entry in each message
 Queue              | SyncML
 Type               | Bug
 State              | Unconfirmed
 Priority           | 1. Low
 Owners             | 
-----------------------------------------------------------------------


patrick.abiven at apitech.fr (2007-02-26 08:43) wrote:

Hello
When synchronizing (reload device) a large number of turba contacts (525),
the last contact of each SyncML message is added (log 'add: <suid>') but
the corresponding uidMap is not created (the log 'created Map for .. ' is
missing). So at the end, we get 512 contacts instead of 525.

It seems that in Sync.php a few lines are missing in createSyncOutput().
After detecting that 'max msg size approached', we still need to add the
last entry, before calling the return statement.

}
line 438: + $output->outputSyncCommand('Add',  
                                                                          
   $clientContent,
                                                                          
   $clientContentType,
                                                                          
   $clientEncodingType,
                                                                          
  null,
                                                                          
  $suid);
line 444: + $this->_server_add_count++;

$messageFull = true;

Hope this helps.
Regards
Patrick