[Tickets #4370] Re: enable / disable, moving of rules, not being saved the first time

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=4370
-----------------------------------------------------------------------
 Ticket             | 4370
 Updated By         | dgehl at inverse.ca
 Summary            | enable / disable, moving of rules, not being saved the first time
 Queue              | Ingo
 Version            | HEAD
 Type               | Bug
 State              | Assigned
 Priority           | 2. Medium
 Owners             | Jan Schneider, Horde Developers
-----------------------------------------------------------------------


dgehl at inverse.ca (2007-03-27 12:03) wrote:

I just found a way to fix this problem on the vacation.php page (a fix for
the other pages should be similar). In fact, the problem seems to be that
not all filter objects are loaded when the first save happens. In my case,
I noticed that when the first save in vacation.php failed, the whitelist
filter got loaded and then, when trying to save the second time (this one
successful), the whitelist filter did not get loaded again.

So to fix the problem in vacation.php, I added all filter objects to the
beginning of the page, which became

/* Get vacation object and rules. */
$vacation = &$ingo_storage->retrieve(INGO_STORAGE_ACTION_VACATION);
$filters = &$ingo_storage->retrieve(INGO_STORAGE_ACTION_FILTERS);

#added to fix http://bugs.horde.org/ticket/comment.php?id=4370
$whitelist = &$ingo_storage->retrieve(INGO_STORAGE_ACTION_WHITELIST);
$forward = &$ingo_storage->retrieve(INGO_STORAGE_ACTION_FORWARD);
$blacklist = &$ingo_storage->retrieve(INGO_STORAGE_ACTION_BLACKLIST);
$spam = &$ingo_storage->retrieve(INGO_STORAGE_ACTION_SPAM);
#end fix

$vac_id = $filters->findRuleId(INGO_STORAGE_ACTION_VACATION);
$vac_rule = $filters->getRule($vac_id);