[Tickets #5250] Funambol to Kronolith, recur_enddate timezone issue

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=5250
-----------------------------------------------------------------------
 Ticket             | 5250
 Created By         | jochem at mondrian.nl
 Summary            | Funambol to Kronolith, recur_enddate timezone issue
 Queue              | SyncML
 Type               | Bug
 State              | Unconfirmed
 Priority           | 2. Medium
 Owners             | 
+New Attachment     | Sync4j.php2.patch
-----------------------------------------------------------------------


jochem at mondrian.nl (2007-04-12 07:15) wrote:

When synchronizing a recurring item with an end (either date or count) from
a windows mobile PDA with the funambol 3.x plugin to kronolith, the last
appointment in kronolith is one before the last appointment on the PDA. 

The funambol plugin converts the enddate on the PDA to Universal Time (for
both end date and recur count), and the date gets stored unmodified in the
kronolith database. Because of DST, I'm now two hours ahead of DST, which
means the enddate is set to two hours before midnight on the endday, so
the day before. This causes the recurrence to end prematurely.

The attached patch converts the PatternEndDate to a timestamp using
mktime, then adds the difference from UTC using date('Z');

I've so far only noticed this issue with the Funambol plugin. I've asked a
colleague of mine to test this using a Nokia device, to see if the problem
is with the import of the vcard (can't imagine so), and not funambol's
implementation.

In the mean time, I've attached the patch for review. Please comment if
this isn't the right way to fix this, so I can learn how to do it
correctly within the Horde framework.