[Tickets #5355] Re: Fix for PHP4 reference handling

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=5355
-----------------------------------------------------------------------
 Ticket             | 5355
 Updated By         | Chuck Hagenbuch <chuck at horde.org>
 Summary            | Fix for PHP4 reference handling
 Queue              | Kronolith
 Version            | HEAD
 Type               | Bug
-State              | Unconfirmed
+State              | Feedback
 Priority           | 1. Low
 Owners             | 
-----------------------------------------------------------------------


Chuck Hagenbuch <chuck at horde.org> (2007-05-14 12:28) wrote:

I know you probably have, but did you test the Share change? There have
been problems in the past with assigning a reference to a static variable
in PHP 4. It may work if the static variable is an array, instead of
overwriting the static directly. But if you have:

static $foo;
...
$foo = &new Bar();

Then the reference won't take.

Also, this should only matter if, in the constructor, the class creates a
child object that needs to be assigned by reference. So I think a lot of
the places you added it in Kronolith are unnecessary. Can you add new
patches that only add the & where it fixes a problem we're seeing?

Thanks!