[Tickets #2565] Re: Gecko Bookmarks extension

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=2565
-----------------------------------------------------------------------
 Ticket             | 2565
 Updated By         | joey at joeyhewitt.com
 Summary            | Gecko Bookmarks extension
 Queue              | Trean
 Type               | Enhancement
 State              | Feedback
 Priority           | 2. Medium
 Owners             | 
+New Attachment     | treanmarks.xpi
-----------------------------------------------------------------------


joey at joeyhewitt.com (2007-05-27 12:30) wrote:

I'm attaching an XPI that should fix this.  Thanks a lot for the detailed
report! - I might not have figured it out otherwise.  Read on for
technical details and request for comments.

Hardcoding is a bad idea!  I've had an assumption in my code for ages, and
I forgot about it.  For simplicity, I hacked in that the root folder would
always have ID 1.  This works great for testing, but if you have more than
one Trean user on the server, I guess it's likely to break.

I think this is what has been happening to you.  I'm attaching a new XPI
with this assumption removed from my code.  It changes the way the menu
appears.  I see now only one folder at the top level, with "joey's
Bookmarks."  (I believe this is called a share.)  Everything that used to
appear at the top level is under that.

I don't have time today, but within this week I'd like to work on more
advanced caching and prefetching, during the course of which I'd like to
offer the ability to remove this extra top-level.  It looks like other
users can share their bookmarks with you, so it may be useful to let the
user pick which "share" to make the top-level.  Other users' bookmarks
would then appear as a "John's Bookmarks" folder.  Anyone have more
suggestions on how to handle the top-level folders (or shares)?

I hope this works for you; it's a shame something so silly on my part has
been holding you up from trying it out. :-)

> I still can't get this to work - now I have even disabled https, to 
> be able to debug a bit more.
> There seems to be a problem with the request TreanMarks is sending, 
> that json.php does not understand:
>
> GET /trean/json.php??method=syncBookmarks&params=%5B1%2C%5B%5D%5D
>
> This results in an
> (...)
> Content-Type: text/javascript
> while(1);/*Not found.*/false
>
> The "params" unescaped seems to be "[1,[]]" - not sure what they 
> should be or if this is in fact correct but something in my horde 
> installation is missing.
>
>