[Tickets #5494] Re: New turba share code issues

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://dev.horde.org/horde/whups/ticket/?id=5494
-----------------------------------------------------------------------
 Ticket             | 5494
 Updated By         | Michael Rubinsky <mrubinsk at horde.org>
 Summary            | New turba share code issues
 Queue              | Turba
 Version            | HEAD
 Type               | Bug
 State              | Accepted
 Priority           | 1. Low
 Owners             | 
-----------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2007-06-23 13:34) wrote:

> Now about the problem with gone addressbooks:
> I didn't gave you full details. I had 2 addressbooks one with 
> sourceId "localsql:vilius at lnk.lt" and one with 
> "mailsql:vilius at lnk.lt". Both had use_shares enabled. I think what 
> happened is when I ran upgrade script, sourceId in datatree backend 
> became "vilius at lnk.lt" for both addressbooks. So this should explain 
> why I saw addressbook with sourceId "mailsql" after the upgrade, and 
> after I deleted it from Turba GUI and from sources.php I've got empty 
> default "localsql" addressbook.  

Looking at this further, this is a bug in the update script - as it
doesn't take into account that in the older datatree two datatree parents
could have children with the same datatree name - as in this case, where
two seperate SQL sources were using shares. We end up with two
datatree_names with a value of the username...

Maybe add a variable or prompt the user for the name of the source-type
(the key in cfgSources) that should be treated as the default source,
leave the datatree names that come from that source as-is, and append
something like the source-type to the datatree names for any other
sources?

Thoughts?