[Tickets #5595] Javascript error in templates/prefs/identityselect.inc (Firefox 2.0.0.5)

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=5595
-----------------------------------------------------------------------
 Ticket             | 5595
 Created By         | veikko.immonen at otaverkko.fi
 Summary            | Javascript error in templates/prefs/identityselect.inc (Firefox 2.0.0.5)
 Queue              | Horde Framework Packages
 Version            | HEAD
 Type               | Bug
 State              | Unconfirmed
 Priority           | 2. Medium
 Owners             | 
+New Attachment     | horde-identityselect.patch
-----------------------------------------------------------------------


veikko.immonen at otaverkko.fi (2007-08-02 01:20) wrote:

I have disabled some of the fields in IMP's personal information options,
for example the sender address field. Personal information is divided into
multiple identities, one of which is chosen and then javascript populates
the appropriate fields. When populating the fields, the script loops over
the identity array, changing the values of the fields one by one. However,
when I have some of the fields disabled and thus non-existent, a javascript
error occurs (at least on Firefox 2.0.0.5, haven't tested other browsers)
when trying to change the value of a non-existent field and the rest of the
fields remain untouched as the browser won't continue to run the
javascript.

I solved this with a simple one-liner; just check to see if the field
actually exists before trying to mangle with it. If it doesn't, just skip
to the next. Patch attached.