[Tickets #56] Re: IMP maintenance should apply to a configurable folder set.

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=56
-----------------------------------------------------------------------
 Ticket             | 56
 Updated By         | Chuck Hagenbuch <chuck at horde.org>
 Summary            | IMP maintenance should apply to a configurable folder set.
 Queue              | IMP
 Version            | HEAD
 Type               | Enhancement
-State              | Stalled
+State              | Feedback
 Priority           | 1. Low
-Owners             | Michael Slusarz
+Owners             | 
-----------------------------------------------------------------------


Chuck Hagenbuch <chuck at horde.org> (2007-09-06 16:23) wrote:

> I've just gotten some more time delegated at work to assist, which I 
> hope can be of maximum effectiveness through your team's support, 
> suggestions, and guidance.

If you're willing to update the patches a bit that could be great. I agree
with you that resolving this is worthwhile, it being one of the oldest
tickets around, plus the bounty, etc.

So, I just took another look at the patches myself, perhaps feeling a bit
clearer. I think one of your primary issues can be resolved with a bit of
info about the prefs system: there are no hooks on special preferences
because they are supposed to define interface elements and they don't have
values.

You should define an implicit preference that actually holds the value/s
you want to store, and leave the special pref to define the UI for it. I
know that's not completely intuitive and it needs to be documented, but
let's stick to the topic. :) So after that hooks should work fine on the
implicit pref.

That means that I think the framework patch can go away entirely. If there
are issues about confirming we should address those separately but that
doesn't apply to solving the issue of this ticket so let's simplify and
leave it out.

The Horde patch is just for hooks.php.dist so that's fine.

In the IMP patch, I'd like to remove the allow_user_confirm_maint bit from
the scope of this ticket, if it's still needed. disable_purge_folders
should be enforceable by locking the preference. I can see the last config
setting (max_days_purge_folders) since that's not easily representable with
a locked preference. But if you don't need it, I'd be inclined to let it
go.

I can look more closely at the rest of the IMP patch if you agree with the
above and can work on revising the patches accordingly.

Michael, if we envision this ticket for now as only providing
configurability for which folders are purged, was there anything else that
concerned with just the IMP portion of the patch?