[Tickets #5207] Re: Make the deliverables billable/non-billable

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=5207
-----------------------------------------------------------------------
 Ticket             | 5207
 Updated By         | Jan Schneider <jan at horde.org>
 Summary            | Make the deliverables billable/non-billable
 Queue              | Hermes
 Type               | Enhancement
 State              | Feedback
 Priority           | 1. Low
 Owners             | 
-----------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2007-10-12 06:22) wrote:

Much better, thanks. There are still a few nits, sorry for being picky:
- The sql upgrade script is for mysql. Please see docs/CODING_STANDARDS
for preferred sql syntax, and other upgrade scripts for examples.
- The default value of a "boolean" field type is already "false", no need
to explicitly specify that.
- Use "empty($var)" instead of "$var == false" especially for
configuration values.
- Add the end of the patch to Driver/sql.php you casted the rate to int
and the billable flag to float, it should be the opposite.