[Tickets #5776] Re: Undefined index: link_all_attachments

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=5776
-----------------------------------------------------------------------
 Ticket             | 5776
 Updated By         | szymon at juraszczyk.com
 Summary            | Undefined index:  link_all_attachments
 Queue              | IMP
 Version            | 4.1.5
 Type               | Bug
 State              | Not A Bug
 Priority           | 1. Low
 Owners             | 
-----------------------------------------------------------------------


szymon at juraszczyk.com (2007-10-26 05:47) wrote:

> Except that you didn't update your configuration, or you didn't log 
> out and back in after saving it.

Hi

I happened to experience the same problem as the one mention in this
ticket and I believe it IS a bug indeed.

There is a code in imp/templates/compose/compose.inc which refers to
$conf['compose']['link_all_attachments'] (lines 527-528):

    $show_link_attach = ($conf['compose']['link_attachments'] &&
!$conf['compose']['link_all_attachments']);
    $show_save_attach = ((strpos($save_attach, 'prompt') === 0) &&
!$conf['compose']['link_all_attachments']);

However, when you set "Should we allow the users to send attachments as
links?" to No while doing initial configuration (via Web),
$conf['compose']['link_all_attachments'] option is not added to conf.php at
all.

A workaround is to manually add

  $conf['compose']['link_all_attachments'] = false;

to conf.php. Contrary to your opinion, looks like a little bug to me. You
obviously did not take into account that not everyone wants this
attachement linking stuff enabled.