[Tickets #5776] Re: Undefined index: link_all_attachments

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=5776
-----------------------------------------------------------------------
 Ticket             | 5776
 Updated By         | szymon at juraszczyk.com
 Summary            | Undefined index:  link_all_attachments
 Queue              | IMP
 Version            | 4.1.5
 Type               | Bug
 State              | Not A Bug
 Priority           | 1. Low
 Owners             | 
-----------------------------------------------------------------------


szymon at juraszczyk.com (2007-10-26 11:45) wrote:

>> You obviously did not take into account that not everyone wants this 
>> attachment
>> linking stuff enabled.
>
> You obviously know more about my state of mind than I do, but I run 
> my dev install and personal site with this disabled, and the 
> configuration is correctly generated with link_all_attachments = 
> false.

I'm not sure how you checked it in your setup, so this is my recipe for
reproducing the problem.

1. Start with an installation of Horde 3.1.5 and IMP 4.1.5. Both products
can (or even should) be more or less set up.
2. Reconfigure Horde for automatic login so that it will be usable in the
next steps.
3. Delete conf.php for IMP.
4. Go to Administration -> Setup menu and enter IMP configuration (it's
status should be displayed as missing at this point).
5. Switch to Compose tab, change 'Should we allow the users to send
attachments as links?' to no. Change nothing else. Generate Mail
Configuration.

This is the config I get by following these steps:

/* CONFIG START. DO NOT CHANGE ANYTHING IN OR AFTER THIS LINE. */
// $Horde: imp/config/conf.xml,v 1.53.2.18 2007/05/03 15:24:51 chuck Exp
$
$conf['utils']['gnupg_keyserver'] = array('pgp.mit.edu');
$conf['utils']['gnupg_timeout'] = '10';
$conf['menu']['apps'] = array();
$conf['user']['select_sentmail_folder'] = false;
$conf['user']['allow_resume_all_in_drafts'] = false;
$conf['user']['allow_folders'] = true;
$conf['user']['allow_resume_all'] = false;
$conf['user']['allow_view_source'] = true;
$conf['user']['alternate_login'] = false;
$conf['user']['redirect_on_logout'] = false;
$conf['server']['change_server'] = false;
$conf['server']['change_port'] = false;
$conf['server']['change_protocol'] = false;
$conf['server']['change_smtphost'] = false;
$conf['server']['change_smtpport'] = false;
$conf['server']['server_list'] = 'none';
$conf['server']['sort_limit'] = '0';
$conf['server']['cache_folders'] = false;
$conf['server']['cache_msgbody'] = false;
$conf['mailbox']['show_attachments'] = false;
$conf['mailbox']['show_preview'] = false;
$conf['mailbox']['show_xpriority'] = false;
$conf['fetchmail']['show_account_colors'] = false;
$conf['fetchmail']['size_limit'] = '4000000';
$conf['msgsettings']['filtering']['words'] = './config/filter.txt';
$conf['msgsettings']['filtering']['replacement'] = '****';
$conf['spam']['reporting'] = false;
$conf['notspam']['reporting'] = false;
$conf['msg']['prepend_header'] = true;
$conf['msg']['append_trailer'] = true;
$conf['compose']['allow_cc'] = true;
$conf['compose']['allow_bcc'] = true;
$conf['compose']['allow_receipts'] = true;
$conf['compose']['special_characters'] = true;
$conf['compose']['use_vfs'] = false;
$conf['compose']['link_attachments'] = false;
$conf['compose']['add_maildomain_to_unexpandable'] = false;
$conf['compose']['attach_size_limit'] = '0';
$conf['compose']['attach_count_limit'] = '0';
$conf['hooks']['vinfo'] = false;
$conf['hooks']['signature'] = false;
$conf['hooks']['trailer'] = false;
$conf['hooks']['fetchmail_filter'] = false;
$conf['hooks']['mbox_redirect'] = false;
$conf['hooks']['mbox_icon'] = false;
$conf['hooks']['spam_bounce'] = false;
$conf['maillog']['use_maillog'] = true;
$conf['tasklist']['use_tasklist'] = true;
$conf['notepad']['use_notepad'] = true;
/* CONFIG END. DO NOT CHANGE ANYTHING IN OR BEFORE THIS LINE. */

As you can see, there is no 'link_all_attachments' option generated, which
still makes sense as this 'link_attachments' is disabled anyway. What seems
inconsistent is that the compose window's code tries to check
'link_all_attachments' option value even though 'link_attachments' is
false.

I can send a patch for compose.inc if the problem should be confirmed.