[Tickets #5878] Horde_Cache sql.php driver does not default to correct table name

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=5878
-----------------------------------------------------------------------
 Ticket             | 5878
 Created By         | brandon.s.ramirez at gmail.com
 Summary            | Horde_Cache sql.php driver does not default to correct table name
 Queue              | Horde Framework Packages
 Version            | HEAD
 Type               | Bug
 State              | Unconfirmed
 Priority           | 1. Low
 Owners             | 
+New Attachment     | Horde_Cache_sql.php.diff
-----------------------------------------------------------------------


brandon.s.ramirez at gmail.com (2007-11-10 16:32) wrote:

The UI for the Horde configuration's 'Cache' tab renders the 'table'
parameter as optional and in brackets specifies a default value of
'horde_cache' for the table name.  However, if you configure the
Horde_Cache_sql driver without a table name, a PHP notice is displayed on
the sidebar multiple times specifying that the key 'table' is missing.

I traced the problem to the 'framework/Cache/Cache/sql.php' file on lines
144 and 186 where it builds the SQL queries using $this->_params['table'].

To make the driver properly default to 'horde_table', I added an in-line
conditional into both lines and created a patch for the file.

See attached.

Versions affected:
HEAD snapshot of 'framework' on 11-05-07.  The CVS browser says the file
was last modified 6 months ago, however, so the issue should still apply.

Steps to reproduce:
1. Configure Horde to use the 'SQL' driver for caching.
2. Leave the table name blank (even if the horde_cache table exists in
your DB)
3. Logout
4. Log back in
5. Look at sidebar