[Tickets #5913] Re: Lower memory usage while downloading files

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=5913
-----------------------------------------------------------------------
 Ticket             | 5913
 Updated By         | Chuck Hagenbuch <chuck at horde.org>
 Summary            | Lower memory usage while downloading files
 Queue              | Gollem
 Version            | HEAD
 Type               | Enhancement
 State              | Feedback
 Priority           | 2. Medium
 Owners             | Chuck Hagenbuch
-----------------------------------------------------------------------


Chuck Hagenbuch <chuck at horde.org> (2007-12-03 21:07) wrote:

> I'm more than happy to help make it work for every filesystem. Took 
> me a while to figure out how to get files out of the cvs system 
> though, but I've got the files you modified. (btw, running Horde 
> 3.1.5 and Gollem H3 1.0.3 for testing).
> Tested your modifications

No, you didn't test the changes to Gollem. You need the VFS updates and
the Gollem changes.

> The thing is though, in the gollem/view.php file there is a line:
>          $data = $GLOBALS['gollem_vfs']->read($filedir, $filename);

http://cvs.horde.org/diff.php?r1=1.60&r2=1.61&f=gollem%2Fview.php

Your view.php looks nothing like the current one in Gollem CVS. See
http://horde.org/source/ if you still need help with CVS.

> For some reason it doesn't copy the file from the VFS to the local 
> filesystem, but you may know why.

... because you're still accessing the VFS. copy() doesn't work the way
you're trying to use it. To copy to a _different_ filesystem (virtual or
otherwise) you need to read the file data.