[Tickets #5960] Re: Automatic creation of default shares leads to creation of unwanted personal address books.

[bugs at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://dev.horde.org/horde/whups/ticket/?id=5960
-----------------------------------------------------------------------
 Ticket             | 5960
 Updated By         | yvon.lafaille at limousin.iufm.fr
 Summary            | Automatic creation of default shares leads to creation of unwanted
                    | personal address books.
 Queue              | Turba
 Version            | 2.2-RC1
 Type               | Bug
 State              | Feedback
 Priority           | 2. Medium
 Owners             | Michael Rubinsky
-----------------------------------------------------------------------


yvon.lafaille at limousin.iufm.fr (2007-12-06 05:37) wrote:

All my thanks for your clear, fast and complete answer

Summary of my answer
I continue to think that each user requires for one and ONLY ONE personal
address book and that this address book does not have to be shared
(shareable?), because it can contain personal addresses like addresses of
the family members.
Although I never yet configured turba with several shared sources, I think
that the solution that you plan, to put a new parameter in sources.php
defining for each shared source if it is necessary to create a personal
address book in this source for each user, is a very flexible and
satisfactory solution for a maximum of different uses of turba.
This parameter could be named : 
'create_personnal_addressbook_in_this_source' => false |  true
This parameter being used only when this source is shared
This parameter could be positioned with  "false" for all the shared
sources when the personal address books of the users are placed on a not
shared source
I prefer this solution compared to the solutions which I had proposed that
I find less flexible.

Details of my answer

>>Description of the problem
>>With the new version of turba (2.2-RC1), a new useless and redundant 
>>personal address book is created for each user at the time of the 
>>access to the address book .
>>    
>>
>
>This is the expected behaviour of our current code. It ensures that each
>user has a personal addressbook created for them automatically.
>
With your respect, I do not think that the goal of the code is to create
useless and redundant address books but I understand that it is essential
to create a personal address book for each user on one (and I think only
one) shared source when the administrator did not define a not shared
source.

>>This new address book is created in the shared sql source, whereas a 
>>personal address book already exists in the source by defect which is 
>>not shared
>>    
>>
>
>Why not use the same source for all the address books?  Each user will
>have his/her own personal address book, and the admins can still create
>additional address books as they do now.

I am not favorable to this solution for several reasons

I think that the personal address books, containing private data,  should
not be shared nor even shareable.

This solution makes unusable the not shared source, since a shared source
exists, and requires to use a script to transform the address books of all
the users existing on the not shared source into address books on the
shared source (I do not think that this script - who would however be
essential for this handling - already exists).

I prefer to maintain the address book of the company which is generated
automatically on a distinct table corresponding to a distinct shared 
source on which the users cannot create address book

>>Moreover, this address book appears in the drop-down list of the 
>>address books for each user, even if it does not appear in the list 
>>of the address books to propose by defect defined in prefs.php
>>    
>>
>
>According to your prefs.php entry below, the pref is not locked, so this
>is expected, the user's default address book for any share would
>automatically be created, and added to the pref.  If you want to prevent
>any changes to the pref, set it to be locked.

To lock this parameter would be a degraded solution because I wish
nevertheless to allow the users to create shared address books

>>$conf['client']['addressbook'] = 'localsql';
>>
>
>Are you using an external application that makes use of the client api? 
>If not, you do not need to set this...and if you *are* using one,
setting
>it to a source that contains only private address books means that each
>user will only see their own personal address books as clients - not
really
>what the clients api was designed for.
>
>

It is an error of me, I thought that this parameter indicated the source
where was the personal address book of each user and that it was thus
possible to know the source where the personal address book of each user
was

> ... automatic creation of personal address books ...
>The other option is to introduce a new config param
>in sources.php to configure this per source, but we are trying to reduce
>the number of configuration settings, not increase them.

I think however that it is the best solution because it does not withdraw
any functionality and adds flexibility without imposing anything

Respectful greetings