[Tickets #6012] Re: Password expiration for Sun/Fedora Directory Server

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=6012
-----------------------------------------------------------------------
 Ticket             | 6012
 Updated By         | marco at csita.unige.it
 Summary            | Password expiration for Sun/Fedora Directory Server
 Queue              | Horde Framework Packages
 Version            | HEAD
 Type               | Enhancement
 State              | Feedback
 Priority           | 1. Low
 Owners             | 
+New Attachment     | ldap.php.patch
-----------------------------------------------------------------------


marco at csita.unige.it (2007-12-20 13:22) wrote:

> Does specifying the list of attributes to fetch cause any problems if 
> those attributes don't exist?

According to RFC 2251 if "there are attribute descriptions in the list
which are not recognized, they are ignored by the server."
However, I test the code with OpenLDAP and Fedora DS without trouble.

> Please avoid code for "shouldn't happen" situations. If a specific 
> potential fault is being protected against, the comment should 
> indicate that. Should it really be a login failure if there's bad 
> data in this field?

You are right. I think as LDAP administrator, for which a wrong data
format is a serious trouble.
But final user don't care about it. Instead of raising an error, I log a
message.

> Also, please use pcre (preg_match) instead of ereg in all Horde code 
> - it's much faster. If you could take a quick read through 
> horde/docs/CODING_STANDARDS that would be wonderful, for this or 
> future contributions, but I can fix this patch (whitespace mostly) as 
> it's small.

Done.