[Tickets #6043] php-error on login page caused by lib/Horde/Share.php (kolab)

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=6043
-----------------------------------------------------------------------
 Ticket             | 6043
 Created By         | m.gabriel at das-netzwerkteam.de
 Summary            | php-error on login page caused by lib/Horde/Share.php (kolab)
 Queue              | Kolab
 Type               | Bug
 State              | Unconfirmed
 Priority           | 3. High
 Owners             | 
-----------------------------------------------------------------------


m.gabriel at das-netzwerkteam.de (2007-12-24 19:13) wrote:

i am using kolab-2.1 (debian unstable) and horde-webmail-1.1rc1

some more php error sedation for the login paged caused by
non-authenticated IMAP access attempts:

Warning: Illegal offset type in isset or empty in
/usr/local/share/_horde-versions_/horde-webmail-1.1-rc1-netzwerkteam/lib/Horde/Share.php
on line 236

the error is occurs thrice on every login page, here are the relating
syslog entries of the occurring errors:

Dec 25 00:08:01 grimnir cyrus/imap[6994]: badlogin: localhost [127.0.0.1]
plaintext  SASL(-1): generic failure: All-whitespace username.
Dec 25 00:08:04 grimnir HORDE[11104]: [kronolith] No object requested. [on
line 1302 of
"/usr/local/share/_horde-versions_/horde-webmail-1.1-rc1-netzwerkteam/kronolith/lib/Kronolith.php"]

Dec 25 00:08:04 grimnir cyrus/imap[6996]: badlogin: localhost [127.0.0.1]
plaintext  SASL(-1): generic failure: All-whitespace username.
Dec 25 00:08:07 grimnir HORDE[11104]: [nag] No object requested. [on line
276 of
"/usr/local/share/_horde-versions_/horde-webmail-1.1-rc1-netzwerkteam/nag/lib/Nag.php"]
Dec 25 00:08:07 grimnir HORDE[11104]: [nag] No object requested. [on line
276 of
"/usr/local/share/_horde-versions_/horde-webmail-1.1-rc1-netzwerkteam/nag/lib/Nag.php"]

Dec 25 00:08:07 grimnir cyrus/imap[6997]: badlogin: localhost [127.0.0.1]
plaintext  SASL(-1): generic failure: All-whitespace username.
Dec 25 00:08:10 grimnir HORDE[11104]: [nag] Unable to authenticate with
the Kolab IMAP server [on line 1689 of
"/usr/local/share/_horde-versions_/horde-webmail-1.1-rc1-netzwerkteam/lib/Horde/Kolab/IMAP.php"]

here is the sedation patch:

diff -r horde-webmail-1.1-rc1/lib/Horde/Share.php
horde-webmail-1.1-rc1-netzwerkteam/lib/Horde/Share.php
233,254c233,256
<         $missing_ids = array();
<         foreach ($cids as $cid) {
<             if (isset($this->_shareMap[$cid])) {
<                 $all_shares[$this->_shareMap[$cid]] =
&$this->_cache[$this->_shareMap[$cid]];
<             } else {
<                 $missing_ids[] = $cid;
<             }
<         }
<
<         if (count($missing_ids)) {
<             $shares = &$this->_getShares($missing_ids);
<             if (is_a($shares, 'PEAR_Error')) {
<                 return $shares;
<             }
<
<             foreach (array_keys($shares) as $key) {
<                 $this->_cache[$key] = &$shares[$key];
<                 $this->_cache[$key]->setShareOb($this);
<                 $this->_shareMap[$shares[$key]->getId()] = $key;
<                 $all_shares[$key] = &$this->_cache[$key];
<             }
<         }
---
>       if ($this->_shareMap) {
>           $missing_ids = array();
>           foreach ($cids as $cid) {
>                 if  (isset($this->_shareMap[$cid])) {
>                   $all_shares[$this->_shareMap[$cid]] =
&$this->_cache[$this->_shareMap[$cid]];
>               } else {
>                   $missing_ids[] = $cid;
>                 }
>           }
>
>           if (count($missing_ids)) {
>               $shares = &$this->_getShares($missing_ids);
>                 if (is_a($shares, 'PEAR_Error')) {
>                   return $shares;
>               }
>
>                 foreach (array_keys($shares) as $key) {
>                   $this->_cache[$key] = &$shares[$key];
>                   $this->_cache[$key]->setShareOb($this);
>                   $this->_shareMap[$shares[$key]->getId()] = $key;
>                   $all_shares[$key] = &$this->_cache[$key];
>                 }
>           }
>       }

mike