[Tickets #6046] _save in lib/Horde/Kolab/XML/contact.php fails on address book import

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=6046
-----------------------------------------------------------------------
 Ticket             | 6046
 Created By         | m.gabriel at das-netzwerkteam.de
 Summary            | _save in lib/Horde/Kolab/XML/contact.php fails on address book import
 Queue              | Kolab
 Type               | Bug
 State              | Unconfirmed
 Priority           | 2. Medium
 Owners             | 
+New Attachment     | contact-xml.patch
-----------------------------------------------------------------------


m.gabriel at das-netzwerkteam.de (2007-12-25 15:00) wrote:

i am using kolab-2.1 (debian unstable) and horde-webmail-1.1rc1

error:
when importing a simple CSV address book (LASTNAME, FIRSTNAME, EMAIL) into
turba (using kolab driver), the following error occurs (the given line
number is not correct as it refers to the already patched and commented out
code):

Notice: Undefined index: full-name in
/usr/local/share/_horde-versions_/horde-webmail-1.1-rc1-netzwerkteam/lib/Horde/Kolab/XML/contact.php
on line 395

the error occurs in this code snippet:

<snip>
        foreach ($emails as $email) {
            $email = trim($email);
            if (!empty($email)) {
                $new_email = array('display-name' =>
$object['name']['full-name'],
                                   'smtp-address' => $email);
                $object['email'][] = $new_email;
            }
        }
</snap>

reason: 
when using the example 'kolab' source in turba's sources.php the
'full-name' key is not an available key in the imported abook object.

solution/workaround:
a patch is attached that might only be regarded as a workaround. probably
the 'map' array of cfgSources['kolab'] should be evaluated instead...
(which tells you how to generate a person's 'full-name').