[Tickets #6222] Re: Check view existence before image load

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/?id=6222
-----------------------------------------------------------------------
 Ticket             | 6222
 Updated By         | Duck <duck at obala.net>
 Summary            | Check view existence before image load
 Queue              | Ansel
 Type               | Enhancement
 State              | Feedback
 Priority           | 1. Low
 Milestone          | 
 Patch              | 
 Owners             | Michael Rubinsky
-----------------------------------------------------------------------


Duck <duck at obala.net> (2008-02-07 03:44) wrote:

> Not passing the $style information was done intentionally so we can 
> control what style is actually shown on the view regardless of the 
> image's gallery's style. In other words, take the blocks for 
> instance, we don't want 3 different styled thumbnails appearing on 
> the Browse page or on Horde's portal page, for example.  The style is 
> only explicitly passed when we want to force the use of that style.

Hmm... in the current code if the style is not passed you cannot control
the style show, because it goes in the DB to get the image style. Yes you
can pass the style and force it, but if don't, you can get many different
styles. And in practice is the same, if you pass the style from previews
retrieved data. So with just little more strict usage you economize a lot
of queries and be still able to force a style in portal blocks.

> It looks like the Ansel_Image::viewExists method you added could 
> still work without those changes though?

Of course not, as you must know the style to calculate the view hash.