[Tickets #6295] Re: Ansel flat shares with hierarchies

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://dev.horde.org/horde/whups/ticket/6295
-----------------------------------------------------------------------
 Ticket             | 6295
 Updated By         | Michael Rubinsky <mrubinsk at horde.org>
 Summary            | Ansel flat shares with hierarchies
 Queue              | Ansel
 Type               | Enhancement
 State              | Assigned
 Priority           | 2. Medium
 Milestone          | 
 Patch              | 
 Owners             | Michael Rubinsky
-----------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2008-03-02 15:38) wrote:

Ok. I looked at this a little closer this afternoon. Maybe I misunderstood
your intentions, but I thought one of the reasons you wanted to do this was
to enable you to use a custom "performance" driver that would combine the
share and gallery data into one table...with the way your splitting the
various classes, your leaving a lot of database specific code behind in the
original Ansel.php file (in Ansel_Gallery and Ansel_Storage, and
Ansel_Image - although the Ansel_Image code is probably ok as I don't think
it touches the galleries table).

I think if we're going to go through the process of moving this to a
"true" driver structure, we need to abstract out *all* the data storage for
the vaious drivers.  Otherwise any drivers that use a different table
structure (as you say your will) will need to override various Ansel_*
methods.

Also, it seems like the Ansel_Share classes in the two different Storage
"drivers" have different interfaces - some of which, at least, is due to
the category methods no being present in the datatree version of the
driver.

I *do* think it's worth moving to a more modular driver structure - but I
think we need to rethink the design, maybe?  As always, I'm open to other's
feedback / suggestions / slaps etc...