[Tickets #6395] Prefs singleton method does not check scope

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6395
-----------------------------------------------------------------------
 Ticket             | 6395
 Created By         | janne.peltonen at helsinki.fi
 Summary            | Prefs singleton method does not check scope
 Queue              | Horde Groupware Webmail Edition
 Version            | 1.1-RC2
 Type               | Bug
 State              | Unconfirmed
 Priority           | 2. Medium
 Milestone          | 
 Patch              | 
 Owners             | 
+New Attachment     | prefs_singleton_fix.patch
-----------------------------------------------------------------------


janne.peltonen at helsinki.fi (2008-03-07 06:11) wrote:

Apparently the Prefs class singleton method does not include the scope of
the Prefs instance into the signature of the instance. This causes trouble
at least with ingo/scripts/convert_imp_filters.php which first causes a
Prefs object of scope 'imp' to be created (in order to load the 'filters'
preference) and then, while wanting to save the converted filters in scope
'ingo' fails - because ingo_storage tries to get the singleton Prefs object
and gets the one of type 'imp' - which has no 'rules' nor 'blacklist' etc.
preferences. Attached patch adds scope to the signature of the singleton
Prefs object - convert_imp_filters.php works after this, but does something
else break?