[Tickets #6424] Possible bug in lib/Horde/MIME/Structure.php

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6424
-----------------------------------------------------------------------
 Ticket             | 6424
 Created By         | tomi.leppikangas at gmail.com
 Summary            | Possible bug in lib/Horde/MIME/Structure.php
 Queue              | Horde Groupware Webmail Edition
 Version            | 1.0.3
 Type               | Bug
 State              | Unconfirmed
 Priority           | 1. Low
 Milestone          | 
 Patch              | 
 Owners             | 
-----------------------------------------------------------------------


tomi.leppikangas at gmail.com (2008-03-11 08:39) wrote:

I noticed that we have problem with mails without content-type headers and
8bit characters.
I know that these are not allowed in standards.
We have configured horde/imp to force to use iso-8859-1 for mails without
charset. (with 
default_msg_charset in imp/config/prefs.php.)

Even with default charset, mails without charset doesn't show accent chars
right. I notised that our imap server gives those mails charset as
'US-ASCII' and horde checks charset as 'us-acii' (lowercase), and does not
set it to default charser. I changes test to 'US-ASCII', and broken mails 
shows ok now.

So i think that test should uppercase charset first, and then compare.
Here is patch for that:


--- ../horde-webmail-1.0.1/lib/Horde/MIME/Structure.php 2007-03-16
21:24:26.000000000 +0200
+++ lib/Horde/MIME/Structure.php        2008-03-11 14:33:48.000000000
+0200
@@ -161,7 +161,7 @@

         /* Set the default character set. */
         if (($ob->getPrimaryType() == 'text') &&
-            ($ob->getCharset() == 'us-ascii') &&
+            (String::upper($ob->getCharset()) == 'US-ASCII') &&
             isset($GLOBALS['mime_structure']['default_charset'])) {
            
$ob->setCharset($GLOBALS['mime_structure']['default_charset']);
         }