[Tickets #6406] Re: Limit download option

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6406
-----------------------------------------------------------------------
 Ticket             | 6406
 Updated By         | Michael Rubinsky <mrubinsk at horde.org>
 Summary            | Limit download option
 Queue              | Ansel
 Type               | Enhancement
-State              | Assigned
+State              | Feedback
 Priority           | 1. Low
 Milestone          | 
 Patch              | 
 Owners             | Michael Rubinsky
-----------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2008-03-14 18:49) wrote:

You are only checking for a locked preference when a gallery is created or
edited...not when checking if the image can be downloaded.  I'm assuming
that the point in locking the pref would be for the admin to force the pref
on all users and all galleries.  If that's so, then the better thing to do
IMO would be to either use a config option instead, or to check the locked
status inside Ansel_Gallery::canDownload() so we are really enforcing it. 
Existing galleries could have been created with a different value before
the pref was locked and, perhaps more importantly, with some pref backends
it might be possible for the user to modify the data, thus overriding the
locked pref.