[Tickets #6556] Re: Large IMSP books/groups slow every page request

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6556
-----------------------------------------------------------------------
 Ticket             | 6556
 Updated By         | Michael Rubinsky <mrubinsk at horde.org>
 Summary            | Large IMSP books/groups slow every page request
 Queue              | Turba
 Version            | HEAD
 Type               | Enhancement
 State              | Feedback
 Priority           | 1. Low
 Milestone          |
 Patch              | 1
 Owners             | Michael Rubinsky
-----------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2008-04-09 17:56) wrote:

> When you say that it is "absolutely not accurate for at least two
> IMSP clients," do you mean that it produces inaccurate results, or
> that it does not produce results for those clients?  We are using a
> combination of Turba and Mulberry as IMSP clients, and the improved
> regex catches a good number of groups created by Mulberry.

What I meant was that SEARCHADDRESS does not necessarily return an email
address at all as your statement:

> The email string returned by SEARCHADDRESS contains the full names
> needed to construct the member list (form: "name <email at domain>").

alluded to.  But, looking at your patch, I see that you probably were not
referring to SEARCHADDRESS responses, but to the list of email addresses
contained in the email field...in which case your statement was correct.

To answer your more general questions first: In general I would recommend
separate  patches for Framework packages and applications.  When they are
related, you can but a link to the related patch in the comments.

For your patches, specifically, please open separate enhancement requests
for these patches. I do have some comments off the top though - first of
all, adding new methods to Net_IMSP that Turba 2.2 relies on means we need
to check for the existence of that method in Turba before it's used, and
fall back to some other method if it's not available, since Turba 2.2 does
not *require* Horde 3.2, only 3.x.  However, I think it would be worth the
changes seeing how much of an improvement you are seeing.

Glad to see someone still making use of IMSP ;)