[Tickets #6564] Re: "Photos not found" error in lib/Ansel.php

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6564
-----------------------------------------------------------------------
 Ticket             | 6564
 Updated By         | Michael Rubinsky <mrubinsk at horde.org>
 Summary            | "Photos not found" error in lib/Ansel.php
 Queue              | Ansel
 Type               | Bug
-State              | Feedback
+State              | Resolved
 Priority           | 1. Low
 Milestone          |
 Patch              |
 Owners             | Michael Rubinsky
-----------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2008-04-12 10:36) wrote:

Alright. I finally see what your referring to, I think.  I still don't see
where you would get an error  "pop-up in a new window".  getImages() was
just returning a PEAR_Error - and that error was only being logged to the
horde log...that's it.

Your point is valid though about returning an error when image count == 0,
but I have fixed it somewhat differently.  IMO, a getImages() method
shouldn't care at all, or even have to know about, any subgalleries. I
changed the method to return an empty array() in that case which makes more
sense to me.  I also changed the if-clause in getChildren() to only call
getImages() if we actually have any images. This will save an additional
database query for each page since we already load the image count when we
instantiate the gallery object.

http://lists.horde.org/archives/cvs/Week-of-Mon-20080407/077308.html

Thanks for the report.