[Tickets #6109] Re: optimized sql Share driver

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6109
-----------------------------------------------------------------------
 Ticket             | 6109
 Updated By         | Duck <duck at obala.net>
 Summary            | optimized sql Share driver
 Queue              | Horde Framework Packages
 Version            | HEAD
 Type               | Enhancement
 State              | Assigned
 Priority           | 2. Medium
 Milestone          | 3.2
 Patch              | 1
 Owners             | Duck, Horde Developers, Chuck Hagenbuch
-----------------------------------------------------------------------


Duck <duck at obala.net> (2008-04-17 11:27) wrote:

> Duck-
> can you explain what the check in Horde_Share_sql::_getShareCriteria
> against $conf['share']['no_sharing'] is for? It doesn't appear in the
> other backends, and I'm inclined to remove it here also unless
> there's a reason I'm missing.

As I remember, even when shares are disabled, the default user's share is
still created. Like the default user calendar. Performing the select joins
the users/group table. But those two tables will be always empty. So I add
a check to avoid the JOIN.