[Tickets #6109] Re: optimized sql Share driver

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6109
-----------------------------------------------------------------------
 Ticket             | 6109
 Updated By         | Chuck Hagenbuch <chuck at horde.org>
 Summary            | optimized sql Share driver
 Queue              | Horde Framework Packages
 Version            | HEAD
 Type               | Enhancement
 State              | Assigned
 Priority           | 2. Medium
 Milestone          | 3.2
 Patch              | 1
 Owners             | Duck, Horde Developers, Chuck Hagenbuch
-----------------------------------------------------------------------


Chuck Hagenbuch <chuck at horde.org> (2008-04-17 12:03) wrote:

> As I remember, even when shares are disabled, the default user's
> share is still created. Like the default user calendar. Performing
> the select joins the users/group table. But those two tables will be
> always empty. So I add a check to avoid the JOIN.

Shouldn't the check be the other way then? Right now it only joins in
those tables if no_sharing is enabled? Actually I think it should be
removed, since even if users aren't allowed to control who sees their
shares, someone might create system shares that everyone sees.