[Tickets #6625] Re: imp/lib/SpellChecker/aspell.php test for ecode broken

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6625
-----------------------------------------------------------------------
 Ticket             | 6625
 Updated By         | liamr at umich.edu
 Summary            | imp/lib/SpellChecker/aspell.php test for ecode broken
 Queue              | IMP
 Version            | FRAMEWORK_3
 Type               | Bug
 State              | Feedback
 Priority           | 1. Low
 Milestone          |
 Patch              |
 Owners             |
-----------------------------------------------------------------------


liamr at umich.edu (2008-04-21 15:37) wrote:

I don't actually know any of the PHP developers, so I've tacked a comment
onto one of the bugs I perceived to be applicable (and that was still
allowing comments).  If one of you has an in with the folks at php.net,
could you pursue this?

In the meantime, what about replacing...

        if (($ecode = proc_close($process)) != 0) {

with something like..

        if (strlen($out) == 0) {

or

        if (empty($out)) {

if there's a problem invoking aspell, $out stays empty, but $err gets
filled.. so this seemed like it might work ok?