[Tickets #6640] Creating a new folder for spam doesn't work

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6640
-----------------------------------------------------------------------
 Ticket             | 6640
 Created By         | janne.peltonen at helsinki.fi
 Summary            | Creating a new folder for spam doesn't work
 Queue              | Ingo
 Version            | 1.2-RC2
 Type               | Bug
 State              | Unconfirmed
 Priority           | 2. Medium
 Milestone          |
 Patch              |
 Owners             |
-----------------------------------------------------------------------


janne.peltonen at helsinki.fi (2008-04-23 08:25) wrote:

Creating a new folder for spam does not work. If I select the option for
creating a new folder in ingo/spam.php, I get the window asking for the
name of the spam folder OK, the script gets activated - with an empty
string as the argument to fileinto, and with no new folder created on the
imap server. Tracing the error in ingo/spam.php, I found something weird in
the if-elsif-construction in lines 81-122. Apparently, the new spam folder
gets created and set as the spam folder only in case the test
$form->validate($vars) in line 82 fails. But if the script is handling the
form request created by the new_folder.js javascript, the test succeeds,
and $spam->setSpamFolder($vars->get('folder')) (line 83) sets the spam
folder to the value of 'folder' - i.e., an empty string.

Apparently, the validate() method should return false if all required
variables aren't set. But it appears to be ok for the method that the
variables are (implicitely) empty...