[Tickets #6722] Re: persistent_params not set or asked in conf.xml

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6722
-----------------------------------------------------------------------
 Ticket             | 6722
 Updated By         | Michael Slusarz <slusarz at horde.org>
 Summary            | persistent_params not set or asked in conf.xml
 Queue              | Horde Framework Packages
 Version            | HEAD
 Type               | Bug
-State              | Unconfirmed
+State              | Not A Bug
 Priority           | 1. Low
 Milestone          |
 Patch              |
 Owners             |
-----------------------------------------------------------------------


Michael Slusarz <slusarz at horde.org> (2008-05-20 03:51) wrote:

> When using e.g. the sql session handler together with memcache
> conf.xml is not setting or asking for the persistent_params used in
> SessionHandler.php.
>
>         if ($driver == 'memcached') {
>             // Trap for old driver name.
>             $driver = 'memcache';
>         } elseif (($driver != 'memcache') &&
!empty($params['memcache'])) {
>             $driver = 'memcache';
>             unset($params['memcache']);
>             $persistent_params = array('persistent_driver' =>
> $driver, 'persistent_params' => $params);
>             $params = null;
>         }

Why do we need to define 'persistent_params' in conf.xml?  All this code
is doing is saving the original params (for the persistent driver) so that
the memcache driver can later pass these params on to the persistent
driver.  It's just a temporary holding place to allow us to pass driver
information between classes.  $driver is replaced with 'memcache' and
$params is replaced with the params needed for the 'memcache' driver, so we
need a way to make sure the original values aren't blown away.

Nowhere are we trying to load 'persistent_params' from the conf.xml, and
there is absolutely no reason we would ever want to.