[Tickets #6729] Re: borken 2.1_to_2.2_sql_schema.php

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6729
-----------------------------------------------------------------------
 Ticket             | 6729
 Updated By         | Michael Rubinsky <mrubinsk at horde.org>
 Summary            | borken 2.1_to_2.2_sql_schema.php
 Queue              | Turba
 Version            | HEAD
 Type               | Bug
 State              | Unconfirmed
 Priority           | 1. Low
 Milestone          |
 Patch              |
 Owners             |
-----------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2008-05-21 09:54) wrote:

>
> Notice: Undefined variable: names in
> /var/www/html/horde/turba/scripts/upgrades/2.1_to_2.2_sql_schema.php
> on line 145

Either this file is not from HEAD, or was modified. Line 145 contains no
reference to the $names variable.

> the docs/UPGRADING file says to manually  change the three
> variables at the top of the script ``$db_user``, ``$db_pass`` and
> ``$db_table``, but why not use the global configuration settings ?

$db_table - there could be multiple sql sources configured in Turba, we
have no way of knowing which on the admin wants to update.

$db_user/$db_pass - Ideally, the user set up in the global configuration
settings shouldn't have the permissions to perform the ALTER / CREATE
statements, so these are used to provide the user information that _does_
have these permissions.