[Tickets #6837] Re: Singletons and references

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6837
-----------------------------------------------------------------------
 Ticket             | 6837
 Updated By         | Thomas Jarosch <thomas.jarosch at intra2net.com>
 Summary            | Singletons and references
 Queue              | Horde Framework Packages
 Version            | HEAD
 Type               | Bug
 State              | Assigned
 Priority           | 1. Low
 Milestone          |
 Patch              |
 Owners             | Thomas Jarosch
-----------------------------------------------------------------------


Thomas Jarosch <thomas.jarosch at intra2net.com> (2008-06-06 05:21) wrote:

> This last patch is a bit confusing, since some places you're adding
> references too.

Yes, this fixes the factory/singleton code for PHP4. You can drop that
part if you want as I switched to PHP5 and PHP4 is out of maintenance
(->doomed) anyway.
I only added it in places where the factory and singleton code is already
defined as "function &factory()" and "function &singleton()", so it should
make no difference. I'm really happy they changed the default "copy"
behavior in PHP5 :-)

Regarding the logger change: The $logger variable is defined as a normal
"static" var, so the code looked wrong to me. Do you have a test case where
it failed in the past? Normal logging f.e. of IMAP logins still works for
me with the new code.