[Tickets #6888] Re: missing column in function _renderVarDisplayEnd Form/Renderer.php

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6888
-----------------------------------------------------------------------
 Ticket             | 6888
 Updated By         | michael.menge at zdv.uni-tuebingen.de
 Summary            | missing column in function _renderVarDisplayEnd
Form/Renderer.php
 Queue              | Horde Framework Packages
 Version            | FRAMEWORK_3
 Type               | Bug
 State              | Feedback
 Priority           | 1. Low
 Milestone          |
 Patch              |
 Owners             |
+New Attachment     | Vacation.png
-----------------------------------------------------------------------


michael.menge at zdv.uni-tuebingen.de (2008-06-11 03:15) wrote:

> Can you please point out a place in a Horde app where this happens,
> or supply a small script to reproduce the problem?


I don't know if this would happen in a normal Hordeinstallation.
We want to disallow our users to edit the "My email Addresses" field in
Ingo Vacaions,
Therefor we patched ingo/vacation.php. See the Attached Image

horde/ingo# diff -u vacation.php.orig  vacation.php
--- vacation.php.orig   2008-05-01 00:11:50.000000000 +0200
+++ vacation.php        2008-06-10 15:13:30.000000000 +0200
@@ -50,7 +50,7 @@
 $form->setSection('advanced', _("Advanced Settings"));
 if (empty($conf['hooks']['vacation_addresses']) ||
     empty($conf['hooks']['vacation_only'])) {
-    $v = &$form->addVariable(_("My email addresses:"), 'addresses',
'longtext', true, false, null, array(5, 40));
+    $v = &$form->addVariable(_("My email addresses:"), 'addresses',
'longtext', true, true, null, array(5, 40));
     $v->setHelp('vacation-myemail');
 }
 $v = &$form->addVariable(_("Addresses to not send responses to:"),
'excludes', 'longtext', false, false, null, array(10, 40));
---------------------------------------------------

I think this may happen in any Form where Readonly and Readwrite Variables
are used, but i don't
konw if this is happening anywhere else. If it happens anyware else in
Horde there is a 50% chance that we don't see it.

In case of readonly the functions  _renderVarDisplayBegin and
_renderVarDisplayEnd are used instad of _renderVarInputBegin and
_renderVarInputEnd which have one column less.
The other idea would be not to call _renderVarDisplay* but
_renderVarInput* and parse the readonlyflag to  _renderVarInput* so that
readonly option is inserted in the input htmltag