[Tickets #6907] Options - Column display fields can be hidden with multiple sources

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6907
-----------------------------------------------------------------------
  Ticket             | 6907
  Created By         | mark.manning at nexussafe.com
  Summary            | Options - Column display fields can be hidden  
with multiple sources
  Queue              | Turba
  Version            | 2.2
  Type               | Enhancement
  State              | New
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
+New Attachment     | columnselect.inc.patch
-----------------------------------------------------------------------


mark.manning at nexussafe.com (2008-06-12 14:21) wrote:

On the column options prefs page, if you have multiple sources with  
the same field names and one or more of those fields is selected for  
display in one source it will not be a visible for selecting in the  
other sources.  Note that this only applies if you have saved the  
setting and come back to the page.

Attached is a patch that should fix the problem.  The cause was that  
the selected fields array was not cleared so if the next source had no  
selections you never went into the "selected items" loop but used  
those field names to to skip over in the "unselected items" loop that  
followed.