[Tickets #6961] Turba / Hermes upgrade causes client addressbook to be ignored.

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6961
------------------------------------------------------------------------------
  Ticket             | 6961
  Created By         | kyrian at ore.org
  Summary            | Turba / Hermes upgrade causes client addressbook to be
                     | ignored.
  Queue              | Hermes
  Type               | Bug
  State              | Unconfirmed
  Priority           | 3. High
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


kyrian at ore.org (2008-06-20 07:01) wrote:

Hi Guys,

More spam from me about Horde because I picked a silly time to upgrade  
to a nightly snapshot ;-)

But hopefully the comment will prove useful, if not, please ignore ;-)

I've just tried going from:

turba-h3-2.1.7 / hermes-HEAD-2008-01-18 / whups-HEAD-2008-02-21

To:

turba-h3-2.2.1 / hermes-HEAD-2008-06-19 and hence  
whups-HEAD-2008-06-19 having seen the former two stop working.

Which was to no avail, so I have reverted.

Basically what happens with the latter configuration from a UI point  
of view is that the default addressbook is being used, and the client  
addressbook is being ignored.

I had hoped a reasonably easy fix could present itself and hence be  
added to the Hermes docs I've already provided, so I looked for one.

It seems to come down to that in _turba_search [via  
Hermes::listClients()] a call to Turba::getAddressBookOrder is doing  
something to wipe the client addressbook out of the list, and hence  
it's being ignored, and you end up with gaps in the client column of  
your timesheet listing.

I think it is probably doing the wrong thing by not treating the  
client addressbook as a 'special case' and ignoring it... either that  
or Hermes should use a different part of the Turba lib/api.php  
functionality.

I've tried merging config, sources and registry entries from my old  
and new versions together, including the extra 'provides' for Turba  
which looked the most likely culprit, combined with the 'addressbooks'  
pref in the latest version:

'clients/getClientSource', 'clients/clientFields',  
'clients/getClient', 'clients/getClients', 'clients/addClient',  
'clients/updateClient', 'clients/deleteClient', 'clients/searchClients'

...  and that just got messy and caused loops in the pages, so I gave  
up on that and just reverted.

Hope it helps in some way, if not, then never mind, although if I  
could get a heads-up when it's fixed or worked around, that would be  
appreciated, as I probably need to be able to upgrade Turba on account  
of the recently announced security issue.

Yours,

Kev,
oRe Net.

PS. Looking back on it I am not sure if Turba being upgraded on its  
own without Hermes being upgraded causes the issue, but I am fairly  
sure that's why I continued to upgrade the other two in the first place.