[Tickets #6994] Re: Fatal error in IMP::parseIndicesList method (Unsupported operand types)

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6994
------------------------------------------------------------------------------
  Ticket             | 6994
  Updated By         | asmarre at ull.es
  Summary            | Fatal error in IMP::parseIndicesList method
                     | (Unsupported operand types)
  Queue              | IMP
  Version            | 4.1.3
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


asmarre at ull.es (2008-06-30 05:16) wrote:


The code I pasted in this comment has been already patched, the  
original code follows. I also forgot to put the filename: lib/IMP.php

        } else {
             /* We are dealing with format #2. */
             foreach ($indices as $key => $val) {
                 if ($GLOBALS['imp_search']->isSearchMbox($key)) {
                     $msgList += IMP::parseIndicesList($val);
                 } else {
                     /* Make sure we don't have any duplicate keys. */
                     $msgList[$key] = is_array($val) ?  
array_unique($val) : array($val);
                 }
             }
         }

>
> Some users complain about an error that appears when they reply an email:
>
> Fatal error: Unsupported operand types in
> /usr/share/horde3/imp/lib/IMP.php on line 1143
>
> My guess is that the recursive call in the line 1143 sometimes return
> false and then the + operation fail:
>
>       } else {
>             /* We are dealing with format #2. */
>             foreach ($indices as $key => $val) {
>                 if ($GLOBALS['imp_search']->isSearchMbox($key)) {
>                     $res = IMP::parseIndicesList($val);
>                     if ($res) $msgList += $res;
>                 } else {
>                     /* Make sure we don't have any duplicate keys. */
>                     $msgList[$key] = is_array($val) ?
> array_unique($val) : array($val);
>                 }
>             }
>         }
>
> I attach a patch.
>