[Tickets #7083] Re: SyncML\Backend.php: $_packetNum not used

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/7083
------------------------------------------------------------------------------
  Ticket             | 7083
  Updated By         | Jan Schneider <jan at horde.org>
  Summary            | SyncML\Backend.php: $_packetNum not used
  Queue              | SyncML
  Type               | Bug
-State              | Unconfirmed
+State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2008-07-18 05:21) wrote:

> It seems that the variable name $_packetNum is not used. The log
> function is using a local variable $packetNum (and not $_packetNum).

Correct, I removed the property, thanks.

> In some cases (when multiples synchronization occur at the same
> time), the packetNum is not incremented, and some log files may be
> used twice (see an extract from syncml_log.txt).

This could be solved by locking the packetnum.txt file while the  
logfile is written, but I don't see the point in it, since this is  
really only for debugging purposes, and you should only debug in a  
controlled environment, i.e. where you can make sure that only a  
single device/user/sync session is tested.