[Tickets #7251] Re: Add an option to hide the script icon in ingo

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/7251
------------------------------------------------------------------------------
  Ticket             | 7251
  Updated By         | yann at pleiades.fr.eu.org
  Summary            | Add an option to hide the script icon in ingo
  Queue              | Ingo
  Version            | 1.2
  Type               | Enhancement
  State              | Resolved
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Jan Schneider
------------------------------------------------------------------------------


yann at pleiades.fr.eu.org (2008-09-01 06:37) wrote:

I think there is an error in the applied patch.
I thought script icon would not be displayed if the auto_update is  
locked and set.
Right now is not displayed is only auto_update is locked and unset

Shouldn't the patch rather be:

@@ -395,7 +395,9 @@ class Ingo {
          if (in_array(INGO_STORAGE_ACTION_SPAM,  
$_SESSION['ingo']['script_categories'])) {
              $menu->add(Horde::applicationUrl('spam.php'),  
_("S_pam"), 'spam.png');
          }
-        if ($_SESSION['ingo']['script_generate']) {
+        if ($_SESSION['ingo']['script_generate'] &&
+            !($GLOBALS['prefs']->isLocked('auto_update') &&
+             $GLOBALS['prefs']->getValue('auto_update'))) {
              $menu->add(Horde::applicationUrl('script.php'),  
_("_Script"), 'script.png');
          }
          if (!empty($GLOBALS['ingo_shares']) &&  
empty($GLOBALS['conf']['share']['no_sharing'])) {