[Tickets #7301] fix bug: sftp operations in VFS/ssh2.php do not work due to escapeshellarg

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/7301
------------------------------------------------------------------------------
  Ticket             | 7301
  Created By         | odie at cs.aau.dk
  Summary            | fix bug: sftp operations in VFS/ssh2.php do not work
                     | due to escapeshellarg
  Queue              | Horde Framework Packages
  Version            | FRAMEWORK_3
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             |
+New Attachment     | horde-ssh2.php.diff
------------------------------------------------------------------------------


odie at cs.aau.dk (2008-09-08 04:42) wrote:

The filename argument for the ssh2_sftp_* functions should not be  
escapeshellarg'ed, white spaces and other special characters are  
already handled fine by these functions. This is opposed to the  
ssh_scp_* functions that do require them.

The escapeshellarg was introduced when trying to fix a problem where  
the ssh_scp_* functions did not use escapeshellarg (bug #6756). Chuck  
Hagenbuch must have guessed that the ssh2_sftp_* functions required  
them too, but neither he nor the reporter of the bug seemed to have  
actually tested any codepaths that uses the ssh2_sftp_* functions.

Attached is a patch that reverts the code for the ssh_sftp_* functions  
to the state before the 'fix'.

I'm CC'ing the people involved in bug #6756 to get their statement.