[Tickets #7380] Re: strip style attributes code and Firefox 3.0.1 (Mozilla 5)

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/7380
------------------------------------------------------------------------------
  Ticket             | 7380
  Updated By         | agerhard at usp.br
  Summary            | strip style attributes code and Firefox 3.0.1 (Mozilla
                     | 5)
  Queue              | Horde Base
  Version            | 3.2.2
  Type               | Bug
  State              | Feedback
  Priority           | 2. Medium
  Milestone          |
  Patch              |
  Owners             |
+New Attachment     | bad_message.txt
------------------------------------------------------------------------------


agerhard at usp.br (2008-09-23 17:45) wrote:

> This has nothing to do with each other. It's always possible that an
> HTML message is breaking the page layout, you have to live with that
> if you enable inline rendering of HTML messages.

Yes, I know.

> That being said, we *do* filter out style tags for any browser when
> rendering those messages inline. It's a bug if that doesn't happen.

But the style tags are not being filtered out, because of the Mozilla version.
The code from html.php is:

$strip_style_attributes = (($browser->isBrowser('mozilla') &&
                                     $browser->getMajor() == 4) ||
                                    $browser->isBrowser('msie'));

So when $browser->getMajor() == 5, $strip_style_attributes = 0

If I change the code to accept the 5 version, then strip_style_attributes = 1
and the page is rendered ok.

> Please upload an example message.

Uploaded as an attachment.