[Tickets #7436] API _replace method doesn't work

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/7436
------------------------------------------------------------------------------
  Ticket             | 7436
  Created By         | almarin at um.es
  Summary            | API _replace method doesn't work
  Queue              | Mnemo
  Version            | 2.2.1
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
+New Attachment     | api.php.patch
------------------------------------------------------------------------------


almarin at um.es (2008-10-06 04:52) wrote:

I've noticed that _replace method doesn't work properly. The steps it  
follows are:
- It creates an Horde_iCalendar object
- It creates an Horde_iCalendar_vNote component with  
Horde_iCalendar::newComponent, with the previous Horde_iCalendar  
object as container
- Then, it parse the "content" string

Result:

- Horde_iCalendar object creates an new component vNote, ignoring the  
previous vNote creates, so you have an vNote empty object with a  
cantainer that has another vNote (this one with the correct data).
- In Driver fromiCalendar method, it extracts the empty vNote

I'm not sure if it is a bug of Horde_iCalendar class. Any way, i think  
that _replace in mnemo should follow the same steps as _replace nag's  
method, or even _import mnemo's method, i mean:

- Creating Horde_iCalendar object
- Parse directly the "content" string
- Extracts the component with Horde_iCalendar::getComponents()

I attach a patch. The modification has been extracted from _replace  
nag's method.