[Tickets #7675] Re: Missing argument 7 for Whups_Driver::mail()

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/7675
------------------------------------------------------------------------------
  Ticket             | 7675
  Updated By         | stevens at stevens.it
  Summary            | Missing argument 7 for Whups_Driver::mail()
  Queue              | Whups
  Version            | 1.0
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


stevens at stevens.it (2008-11-12 14:36) wrote:

maybe just a tweak, however PHP log reports

"PHP Warning:  Missing argument 7 for Whups_Driver::mail(), called in  
/var/www/horde-3.3/whups-h3-1.0/lib/Whups.php on line 751 and defined  
in /var/www/horde-3.3/whups-h3-1.0/lib/Driver.php on line 335"

lib/Whups.php:751
  $whups_driver->mail(null, $user, $subject, $email, $user, true);

it could be ok to put a default for "$queue_id" in Whups_Driver::mail(); e.g.

function mail($ticket_id, $recipients, $subject, $message, $from,
                   $reminder, $queue_id = null, $is_new = false)

later in the function, we can check the "$queue_id" value instead of  
using it directly; e.g.:

         if (!is_null($queue_id)) {
             $queue = $this->getQueue($queue_id);
         } else {
             ...