[Tickets #6982] Re: Optimized Tags

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6982
------------------------------------------------------------------------------
  Ticket             | 6982
  Updated By         | Michael Rubinsky <mrubinsk at horde.org>
  Summary            | Optimized Tags
  Queue              | Ansel
  Type               | Enhancement
-State              | Assigned
+State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2008-11-12 19:55) wrote:

1) This patch does nothing to update the count when a tag is removed.  
You only updating the tags that are passed to Ansel_Tags::writeTags()  
this function *always* overwrites the resources's tags, so your not  
capturing when the tag is removed.

2) Was there any special reason you removed the charset conversion is  
some of the queries?

3) the variable $id is not always set, that is why I was using the  
$reults['tag_id'] value - any special reason you didn't want to use  
that?