[Tickets #7272] Re: Date_Holidays split up breaks translation support for non-christian drivers

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/7272
------------------------------------------------------------------------------
  Ticket             | 7272
  Updated By         | mike at msabal.net
  Summary            | Date_Holidays split up breaks translation support for
                     | non-christian drivers
  Queue              | Kronolith
  Version            | 2.2
  Type               | Bug
  State              | Assigned
  Priority           | 2. Medium
  Milestone          |
  Patch              |
  Owners             | Horde Developers, Jan Schneider
------------------------------------------------------------------------------


mike at msabal.net (2008-12-08 09:03) wrote:

While there may be some issues with holiday locales as reported on the  
PEAR forum, there is a separate issue that results in no holidays  
being displayed and the same locale error being posted to the log.  In  
this situation, the locale error is a phantom.

In kronolith/lib/Driver/holidays.php, on line 83 (version 2.3), the  
line that reads
  $holidays = $dh->getHolidayForDate($date->timestamp(), $GLOBALS['l
anguage'], true);

must be changed to
  $holidays = $dh->getHolidayForDate($date->format('Y-m-d'), $GLOBALS['
language'], true);

Because the date format is wrong, $dh gets set to an error; which end  
up getting reported as a locale error, even though the real problem is  
something else.