[Tickets #7761] Re: Minor updates to fetchmail for multiple driver flexibility

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/7761
------------------------------------------------------------------------------
  Ticket             | 7761
  Updated By         | Jan Schneider <jan at horde.org>
  Summary            | Minor updates to fetchmail for multiple driver
                     | flexibility
  Queue              | IMP
  Version            | 4.3
  Type               | Enhancement
-State              | New
+State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2008-12-12 12:48) wrote:

How is that supposed to work? $driver is always set as soon as a  
driver is chosen, so fetchmailprefs.html is never loaded. A better  
patch would be to split up the current template into one for imap and  
one for pop3 (e.g. without the folder name setting). Then we would  
*always* load a $driver.'fetchmailprefs.php'. Of course you can't use  
$driver exactly this way, because it opens an file-inclusion  
vulnerability.
Further, the preg_match() stuff is of course not a viable solution.  
Instead the driver should specify whether it is able to run on-demand.