[Tickets #7784] Re: Kronolith problem with Holidays

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/7784
------------------------------------------------------------------------------
  Ticket             | 7784
  Updated By         | hmmsjan at kpnplanet.nl
  Summary            | Kronolith problem with Holidays
  Queue              | Horde Groupware Webmail Edition
  Version            | 1.2.1
  Type               | Bug
  State              | Not A Bug
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


hmmsjan at kpnplanet.nl (2008-12-19 02:26) wrote:

How a fix introduces a problem:

function_exists needs a string argument, this is corrected in 1.2.1 and
immediately breaks the 1.2.1 version:

the easter_days function returns the number of days after Mar 21  
instead of a Date object,
and calling a member function of an integer is not possible.


With my poor PHP knowledge it should be moreorless:

  396     function calcEaster($year)
  397     {
  398         if (function_exists('easter_days')) {
  399             $mar21offset= easter_days($year);
  400             $eastern=new Date(sprintf("%04d-03-21",$year));
  401             $eastern->addSeconds($mar21offset*86400);
  402             return($eastern);
  403         }


Kind Regards,