[Tickets #7831] Special folder display with custom images broken in DIMP

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/7831
------------------------------------------------------------------------------
  Ticket             | 7831
  Created By         | Gunnar Wrobel <p at rdus.de>
  Summary            | Special folder display with custom images broken in
                     | DIMP
  Queue              | DIMP
  Version            | HEAD
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


Gunnar Wrobel <p at rdus.de> (2009-01-08 06:12) wrote:

If a folder within IMP has been configured to use a special image via  
the _imp_hook_mbox_icons hook this will lead to a broken folder  
display within DIMP. There will be a line break just after the image  
and the folder name will sit on top of the folder name in the next line.

All other special folders images in DIMP are handled via setting the  
icon as a background image in the css. I don't know if the same would  
be possible for folders with these customized images. _createFolderElt  
within dimp/lib/DIMP.php returns a full image tag (rather than just a  
url). And I don't know if the folder information generated by this  
function is used somewhere else. Otherwise it might be possible to  
modify the funtion to return a url here and add a background image  
style to the item.

A workaround is to add a "float: left" style to the div where the  
image tag is being added. See below.

diff -r 23c541337007 dimp/js/src/DimpBase.js
--- a/dimp/js/src/DimpBase.js   Thu Jan 08 11:03:29 2009 +0100
+++ b/dimp/js/src/DimpBase.js   Thu Jan 08 12:01:58 2009 +0100
@@ -1579,6 +1579,7 @@
          div = new Element('DIV', { className: ob.cl || 'base', id:  
fid + '_div' });
          if (ob.i) {
              div.update(ob.i);
+            div.setStyle(float:left);
          }
          if (ob.ch) {
              div.writeAttribute({ className: 'exp'  
}).observe('mouseover', this.bcache.get('mo_folder') ||  
this.bcache.set('mo_folder', function(e) {